A0-3181: Bump toolchain version #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are now forbidden by the compiler due to: "specialization impl does not specialize any associated items"
fbielejec
reviewed
Sep 4, 2023
| } | ||
|
|
||
| #[ink(message)] | ||
| fn transfer_from( |
There was a problem hiding this comment.
this code is duplicated in psp22/lib.rs. Can't you refactor it to some native Rust trait and use a blanket impl?
fbielejec
reviewed
Sep 4, 2023
| } | ||
| y | ||
| } | ||
|
|
||
| impl PSP22 for PairContract { | ||
| #[ink(message)] | ||
| fn transfer_from( |
There was a problem hiding this comment.
again, a lot of this code is repeated between other contracts and could be reused
There was a problem hiding this comment.
Not a lot, just one method. Here we are actually still using default fns from OpenBrush's PSP22 implementation and overwriting just transfer_from. There is a separate epic to get rid of OB entirely and @h4nsu is working on it.
h4nsu
approved these changes
Sep 4, 2023
|
Since this is a "temporary state" (until we remove all OB dependencies from the repo entirely) I think it's OK to merge as-is. We can revive these discussions when we're "more ready" for them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drinkis not compatible with Rust version used in this project, it requires 1.72+.After bumping to matching version of nightly toolchain, I was getting
error for all occurrences of:
(i.e. empty impl of a trait that has all of its methods implemented as
default fn).I can't remove that b/c then there won't be any methods (no method marked with
#[ink(message)]macro) available on the contract.To fix the above I moved all of the default impls to respective contract files.
For OpenBrush-only traits (like
PSP22andPSP22Metadata) I simply copied their default implementations from the OB repository.This also is an intermediate step towards an OB-less future.
NOTE that this doesn't compile commit-by-commit. I decided to split the changes into commits that show why I had to do things I did, rather than self-contained changes.