Support Pair default fee in RouterV2 #122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggawryal
reviewed
Oct 30, 2024
woocash2
reviewed
Oct 30, 2024
| let fee = match contract_ref.call().get_fee().try_invoke() { | ||
| Ok(Ok(fee)) => fee, | ||
| // is not a Pair contract. | ||
| let token_0 = match contract_ref.call().get_token_0().try_invoke() { |
There was a problem hiding this comment.
Why suddenly like this & why obtain token0 and token1 differently?
There was a problem hiding this comment.
Because the Pair contract may not implement get_fee(), however, it must implement get_token_0() and get_token_1().
Given that get_token_0() call is successful, we assume that the contract is a Pair, and there's no need to control the invocation of the get_token_1().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.