Improve farm setup Python scripts. #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deuszx
commented
Aug 7, 2024
| @@ -102,7 +102,7 @@ def call_contract(chain, keypair, contract_address, metadata_file, method, **kwa | |||
| else: | |||
| error = receipt.error_message | |||
| name, docs = error['name'], error['docs'] | |||
| print(f'!!! Contract call failed with error {name}: {docs}') | |||
| raise ValueError(f'Contract call failed with error {name}: {docs}') | |||
There was a problem hiding this comment.
Changed to raising an exception so that the call short-circuits.
deuszx
changed the title
DamianStraszak
approved these changes
Aug 9, 2024
ggawryal
approved these changes
Aug 12, 2024
ggawryal
added a commit
that referenced
this pull request
Aug 16, 2024
Follow-up to #112: * Add farm contract artifacts: the script looks up contract code by its hash, and builds are non-deterministic, so to make it work on testnet / mainnet we have to use exactly the same code hash. * Add docs for timestamp and AZERO units * Fix `wrap-azero`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wrap-azerosubcommand for easier farm setup where there's A0 as a rewards.increaseAllowanceas part ofstart(farm) subcommand.detailssubcommand is used.