Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A0-4215: Make extender synchronous #436

Merged
merged 2 commits into from
Apr 15, 2024
Merged

A0-4215: Make extender synchronous #436

merged 2 commits into from
Apr 15, 2024

Conversation

timorleph
Copy link
Contributor

One fewer spawn.

@github-actions GitHub Actions
Copy link

Please make sure the following happened

  • Appropriate tests created
  • Infrastructure updated accordingly
  • Updated existing documentation
  • New documentation created
  • Version bumped if breaking changes

@woocash2
Copy link
Contributor

I'm worried that this refactor may have negative impact on the performance. Extender contains relatively heavy logic and now sending out a unit through the network is delayed by it.

Have you considered changing order of operations in on_unit_backup_saved? I.e. is there a chance that the overall performance will be better if self.ordering.add_unit(unit.clone()) was executed at the end of the function?

@timorleph
Compute order extension last
5b1906e 
Probably doesn't actually impact sending delays, but it also doesn't hurt.
@timorleph timorleph merged commit eebbf2b into Cardinal-Cryptography:main Apr 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woocash2 woocash2 woocash2 approved these changes

@lesniak43 lesniak43 lesniak43 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timorleph @woocash2 @lesniak43