A0-4212: Reconstruct synchronously #431

timorleph · 2024-04-03T14:20:29Z

Parent reconstruction now happens synchronously together with validation. This also removes the consensus component, since otherwise it would have just been a thin wrapper around creation. It's likely that runway will eventually be renamed to consensus, but it's not ready yet.

github-actions · 2024-04-03T14:20:42Z

Please make sure the following happened

Appropriate tests created
Infrastructure updated accordingly
Updated existing documentation
New documentation created
Version bumped if breaking changes

Fortunately it seems I actually used all the code.

docs/src/internals.md

consensus/src/dag/reconstruction/mod.rs

consensus/src/runway/mod.rs

consensus/src/dag/mod.rs

lesniak43

looks reasonable to me, although this PR is "slightly" too big

consensus/src/dag/mod.rs

woocash2 · 2024-04-08T15:36:57Z

Overall looks good, ABFT is really getting simpler and more readable.
I found one thing which made me ponder... (my last comment). I'll abstain from accepting the PR for now and wait for the response. Other than that, all clear.

Reconstruct synchronously

e6c89b1

timorleph requested review from lesniak43 and woocash2 April 3, 2024 14:36

Whoops, forgot to remove the clippy workaround

26f4bb0

Fortunately it seems I actually used all the code.

lesniak43 reviewed Apr 8, 2024

View reviewed changes

docs/src/internals.md Outdated Show resolved Hide resolved

lesniak43 reviewed Apr 8, 2024

View reviewed changes

docs/src/internals.md Outdated Show resolved Hide resolved

Numbering in docs

8ae5550