-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A0-4160: Make packing part of unit creation #425
Merged
timorleph
merged 4 commits into
Cardinal-Cryptography:main
from
timorleph:A0-4160-rudderamount
Mar 26, 2024
Merged
A0-4160: Make packing part of unit creation #425
timorleph
merged 4 commits into
Cardinal-Cryptography:main
from
timorleph:A0-4160-rudderamount
Mar 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please make sure the following happened
|
timorleph
force-pushed
the
A0-4160-rudderamount
branch
from
March 13, 2024 10:44
fdd403a
to
7b41708
Compare
timorleph
force-pushed
the
A0-4160-rudderamount
branch
from
March 13, 2024 10:45
7b41708
to
c4e6569
Compare
woocash2
reviewed
Mar 13, 2024
woocash2
reviewed
Mar 13, 2024
woocash2
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this refactor. Taking some load off the runway
.
fixxxedpoint
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another part of the larger refactor. Currently looks a bit weird, because
consensus
becomes more dependent on non-bare-unit stuff technically, but this divide won't make much sense in the future anyway – specific components will be better separated between themselves, rather than having to separate out whole subthreads.