Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A0-4160: Make packing part of unit creation #425

Merged
merged 4 commits into from
Mar 26, 2024

Conversation

timorleph
Copy link
Contributor

Another part of the larger refactor. Currently looks a bit weird, because consensus becomes more dependent on non-bare-unit stuff technically, but this divide won't make much sense in the future anyway – specific components will be better separated between themselves, rather than having to separate out whole subthreads.

Copy link

Please make sure the following happened

  • Appropriate tests created
  • Infrastructure updated accordingly
  • Updated existing documentation
  • New documentation created
  • Version bumped if breaking changes

Copy link
Contributor

@woocash2 woocash2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this refactor. Taking some load off the runway.

Copy link
Contributor

@fixxxedpoint fixxxedpoint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

consensus/src/creation/mod.rs Show resolved Hide resolved
consensus/src/creation/mod.rs Outdated Show resolved Hide resolved
consensus/src/runway/mod.rs Show resolved Hide resolved
@timorleph timorleph merged commit 4795e10 into Cardinal-Cryptography:main Mar 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants