Correct @id return value from r_navigation #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `@id` key in the response from r_navigation is actually the url path to the current navigation request. Here I have changed the return for `@id` to the objectId and moved the url path that was in `@id` to a new `dts:references` key. This seems to make more sense to me but perhaps it doesn't conform to the standard.
|
@PonteIneptique If my changes comply with the expected behavior for the navigation endpoint, then I can also work to update the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@idkey in the response from r_navigation is actually the url path to the current navigation request. Here I have changed the return for@idto the objectId and moved the url path that was in@idto a newdts:referenceskey. This seems to make more sense to me but perhaps it doesn't conform to the standard.