Skip to content

Commit

Permalink
Fix SUNDIALS 7.x compatibility/library list checks
Browse files Browse the repository at this point in the history
  • Loading branch information
speth committed Dec 16, 2024
1 parent 1ef52c9 commit 6e00275
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion SConstruct
Original file line number Diff line number Diff line change
Expand Up @@ -1468,7 +1468,7 @@ if env["system_sundials"] in ("n", "default"):

if env['system_sundials'] == 'y':
env['sundials_libs'] = ['sundials_cvodes', 'sundials_idas', 'sundials_nvecserial']
if parse_version(env["sundials_version"]) >= parse_version("7.2.0"):
if parse_version(env["sundials_version"]) >= parse_version("7.0.0"):
env['sundials_libs'].append('sundials_core')
if env['use_lapack']:
if env.get('has_sundials_lapack'):
Expand Down
2 changes: 1 addition & 1 deletion site_scons/buildutils.py
Original file line number Diff line number Diff line change
Expand Up @@ -1764,7 +1764,7 @@ def check_sundials(conf: "SConfigure", sundials_version: str) -> Dict[str, Union
if should_exit_with_error:
config_error(f"Sundials version must be >=3.0,<8.0. Found {sundials_ver}.")
return {"system_sundials": "n", "sundials_version": "", "has_sundials_lapack": 0}
elif sundials_ver > parse_version("7.0.0"):
elif sundials_ver > parse_version("7.2.0"):
logger.warning(f"Sundials version {sundials_ver} has not been tested.")

cvode_checks = {
Expand Down

0 comments on commit 6e00275

Please sign in to comment.