Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(wren-ui): Fix getting incorrect native sql issue #550

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

onlyjackfrost
Copy link
Contributor

@onlyjackfrost onlyjackfrost commented Jul 24, 2024

Fix issue #520

We previously used Wren Engine to do dry-plan. Now, when the data source is not DuckDB, we use ibis server for dry-plan.

@onlyjackfrost onlyjackfrost changed the title Fix: use ibis server to do dry-plan when data source is not duckdb Fix: use ibis server to do dry-plan Jul 24, 2024
@onlyjackfrost onlyjackfrost changed the title Fix: use ibis server to do dry-plan Fix(wren-ui): Fix getting incorrect native sql issue Jul 24, 2024
@wwwy3y3
Copy link
Member

wwwy3y3 commented Jul 24, 2024

Kindly add some notes on what changed and why

@onlyjackfrost onlyjackfrost merged commit 2d48304 into main Jul 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants