-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input and internal schema validation plus default maxExtent issue #2124
Input and internal schema validation plus default maxExtent issue #2124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @ychoquet)
packages/geoview-core/src/api/config/types/config-constants.ts
line 9 at r1 (raw file):
TypeAppBarProps, TypeBasemapId, TypeBasemapOptions,
Why all those type diseapred from this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r1.
Reviewable status: 1 of 3 files reviewed, 2 unresolved discussions (waiting on @ychoquet)
packages/geoview-core/src/api/config/types/config-validation-schema.json
line 1125 at r1 (raw file):
}, "if": { "properties": {
Because most property of all layer are similar, can we have a type defiition reusable and have one specific by source?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 3 files reviewed, 2 unresolved discussions (waiting on @jolevesq and @ychoquet)
packages/geoview-core/src/api/config/types/config-constants.ts
line 9 at r1 (raw file):
Previously, jolevesq (Johann Levesque) wrote…
Why all those type diseapred from this file
I used a trick proposed by Alex that minimize the as SomeOtherType usage. So, all these types I had to use before are not needed anymore. I use the Cast function which does basically a 'as unknown as newType'. The drawback of this methode is if The object in the Cast does not define a field in the targetted newType, you will not get an error flaged.
packages/geoview-core/src/api/config/types/config-validation-schema.json
line 1125 at r1 (raw file):
Previously, jolevesq (Johann Levesque) wrote…
Because most property of all layer are similar, can we have a type defiition reusable and have one specific by source?
Yes we can, I will do that in my next PR.
c0e809d
to
b5b9676
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ychoquet)
daaaff7
into
Canadian-Geospatial-Platform:develop
Description
This PR groups two issues:
Fixes #2121, 2122
Type of change
How Has This Been Tested?
Using Chrome Devtools to trace and debug the code.
Deploy URL: https://ychoquet.github.io/GeoView/config-sandbox.html
Checklist:
I have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature worksNew and existing unit tests pass locally with my changesThis change is