Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(layer-and-config) - Lists functions from layer that should be moved to config/layerapi #2067

Conversation

Alex-NRCan
Copy link
Member

@Alex-NRCan Alex-NRCan commented Apr 30, 2024

Description

This is a temporary PR to list functions from layer that should be moved to config/layerapi.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Add the URL for your deploy!

Checklist:

  • I have build (rush build) and deploy (rush host) my PR
  • I have connected the issues(s) to this PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have created new issue(s) related to the outcome of this PR is needed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This change is Reviewable

@Alex-NRCan Alex-NRCan self-assigned this Apr 30, 2024
@Alex-NRCan Alex-NRCan force-pushed the feat-layer-refactor branch 3 times, most recently from 95b1635 to 17758ee Compare May 2, 2024 15:01
@Alex-NRCan Alex-NRCan force-pushed the feat-layer-refactor branch 2 times, most recently from f9cd547 to 817933f Compare May 9, 2024 13:14
Progress
Regrouped the obsolete functions
@jolevesq
Copy link
Member

Was there for reference, closed as merged as part of other PR

@jolevesq jolevesq closed this May 29, 2024
@Alex-NRCan Alex-NRCan deleted the feat-layer-refactor branch June 17, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants