Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kde-settings] Move depend package to optional #468

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheWyn
Copy link
Contributor

@TheWyn TheWyn commented Jan 2, 2025

Konsole is installed by default and Alacritty itself is optional in the installer. No need to store config files for a program that likely isn't installed. Make Alacritty depend the config not the DE config.

Konsole is installed by default and Alacritty itself is optional in the installer.  No need to store config files for a program that likely isn't installed.  Make Alacritty depend the config not the DE config.
@vnepogodin
Copy link
Member

vnepogodin commented Jan 2, 2025

I don't see much sense in moving that package to optionals; it would make more sense to remove it from depends entirely (as it will never be installed).

"Settings" (which provide files in /etc/skel) packages exist only to install configurations during system installation.

Regarding Konsole and Alacritty: Alacritty was the default terminal emulator on CachyOS (if you can call it that), and since the KDE configuration is basically "vanilla", Konsole is used.

@vnepogodin
Copy link
Member

vnepogodin commented Jan 2, 2025

The Alacritty settings package was added to the dependencies to provide a drop-in replacement for the config which already existed in the KDE settings package. The purpose was to "unify" multiple settings packages that provided the same Alacritty configuration

@TheWyn
Copy link
Contributor Author

TheWyn commented Jan 2, 2025

It'd be better to add Alacritty to the repo and add the config package as a depend. Current method adds upkeep keeping it in every DE config and regardless if Alacritty is installed or not.

Regarding Konsole and Alacritty: Alacritty was the default terminal emulator on CachyOS (if you can call it that), and since the KDE configuration is basically "vanilla", Konsole is used.

Wasn't that also due to multiple DE options for the live iso download? (Which isn't a thing anymore)

@vnepogodin
Copy link
Member

vnepogodin commented Jan 2, 2025

It'd be better to add Alacritty to the repo and add the config package as a depend. Current method adds upkeep keeping it in every DE config and regardless if Alacritty is installed or not.

Well it's not better, it adds mess into the repository(and "Manjaro" feel. as in being independent distribution).

If user doesn't need 1 file, they can just remove the packages. e.g sudo pacman -R cachyos-kde-settings cachyos-alacritty-config. It has zero effect on the system, as those config files get "used" only at user account creation(during CachyOS installation)

Wasn't that also due to multiple DE options for the live iso download? (Which isn't a thing anymore)

No. It's used for all system installs. Managing spare files not handled by the package manager via dedicated packages is stupid idea in the first place as it is adding mess which can't be easily tracked

@TheWyn
Copy link
Contributor Author

TheWyn commented Jan 2, 2025

It has zero effect on the system, as those config files get "used" only at user account creation(during CachyOS installation)

Removing cachyos-kde-settings turns off HDR for Sddm, that's a no go. I'll fall back to suggest making it optional or removing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants