Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CBRD-25784] Support Clang and GCC-14 Compilers #5766

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

[CBRD-25784] Support Clang and GCC-14 Compilers #5766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8fa8ffe
feat(cmake, headers): support clang by fixing missing includes
vimkim Jan 4, 2025
2ce2527
fix indent
vimkim Jan 13, 2025
213c93e
comply with -Wc++11-narrowing
vimkim Jan 20, 2025
282e69c
comply with -W-implicit-function-declaration
vimkim Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,8 @@ if(UNIX)
set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,--hash-style=both -static-libstdc++")
set(CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} -Wl,--hash-style=both -static-libstdc++")

else(CMAKE_COMPILER_IS_GNUCC)
elseif (CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
else()
message(FATAL_ERROR "We currently do not support ${CMAKE_CXX_COMPILER_ID} compiler")
endif(CMAKE_COMPILER_IS_GNUCC)
else(UNIX)
Expand Down
16 changes: 8 additions & 8 deletions src/object/authenticate_access_auth.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,15 +45,15 @@ const char *AU_TYPE_SET[] =
"EXECUTE" /* DB_AUTH_EXECUTE */
};

const int AU_TYPE_SET_LEN[] =
constexpr int AU_TYPE_SET_LEN[] =
{
strlen ("SELECT"), /* DB_AUTH_SELECT */
strlen ("INSERT"), /* DB_AUTH_INSERT */
strlen ("UPDATE"), /* DB_AUTH_UPDATE */
strlen ("DELETE"), /* DB_AUTH_DELETE */
strlen ("ALTER"), /* DB_AUTH_ALTER */
strlen ("INDEX"), /* DB_AUTH_INDEX */
strlen ("EXECUTE") /* DB_AUTH_EXECUTE */
sizeof ("SELECT") - 1, /* DB_AUTH_SELECT */
sizeof ("INSERT") - 1, /* DB_AUTH_INSERT */
sizeof ("UPDATE") - 1, /* DB_AUTH_UPDATE */
sizeof ("DELETE") - 1, /* DB_AUTH_DELETE */
sizeof ("ALTER") - 1, /* DB_AUTH_ALTER */
sizeof ("INDEX") - 1, /* DB_AUTH_INDEX */
sizeof ("EXECUTE") - 1 /* DB_AUTH_EXECUTE */
};

au_auth_accessor::au_auth_accessor ()
Expand Down
1 change: 1 addition & 0 deletions src/parser/csql_grammar.y
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ extern int msg_ptr;
extern int yybuffer_pos;
extern int is_dblink_query_string;
extern int expecting_pl_lang_spec;
extern int yylex(void);

#if defined(SA_MODE)
/*
Expand Down
1 change: 1 addition & 0 deletions src/transaction/flashback.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@

#ident "$Id$"

#include <algorithm>
#include <map>
#include <unordered_map>
#include <unordered_set>
Expand Down
2 changes: 1 addition & 1 deletion src/xasl/xasl_stream.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ template <typename T>
static void stx_alloc_array (THREAD_ENTRY *thread_p, T *&ptr, std::size_t count);

template <typename T>
void stx_restore (THREAD_ENTRY *thread_p, char *&ptr, T *&target);
static void stx_restore (THREAD_ENTRY *thread_p, char *&ptr, T *&target);

Comment on lines 96 to 98
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
같은 파일 121번째 줄, stx_restore의 function definition에는 static이 명시되어 있음.
그러나 function declaration 에는 static이 없어 최신 컴파일러 버전에서 오류로 인식됨.

//////////////////////////////////////////////////////////////////////////
// Template and inline implementation
Expand Down
Loading