Use cookiecutter hook and tfvar validation to limit service account characters #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falquaddoomi
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Looks reasonable; I left a note about the option of using TF input variable validation to make the user aware of the issue rather than handling it.
I'll approve this, though, and leave the decision up to you since you know better than me what your audience is going to find easier to handle.
{{ cookiecutter.project_name }}/terraform/operations/accounts.tf
Outdated
Show resolved
Hide resolved
Co-Authored-By: Faisal Alquaddoomi <[email protected]>
d33bs
changed the title
|
Thanks @falquaddoomi, I incorporated in your feedback and going to merge now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR limits the number of characters which may be used for the service account name to help abide Google service account constraints (link). It might result in some odd looking names so I also added a comment above the entry within the TF to ensure understandability.
Thanks for any feedback!
Closes #17