Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop capturing all warnings #341

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Stop capturing all warnings #341

merged 2 commits into from
Aug 5, 2024

Conversation

angus-g
Copy link
Collaborator

@angus-g angus-g commented Jul 1, 2024

I expect this might make the indexing output more verbose, since permission errors won't go through the logging mechanism.

There's an additional update to the version mechanism to make it compatible with newer Python versions where pkg_resources no longer exists.

Closes #337.

@navidcy
Copy link
Collaborator

navidcy commented Jul 22, 2024

I like this.

I'm not really sure if I'm in position to properly review.... (meaning I don't understand what really the code changes do here)

@navidcy
Copy link
Collaborator

navidcy commented Aug 5, 2024

@dougiesquire could you review this?

Copy link
Collaborator

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@navidcy
Copy link
Collaborator

navidcy commented Aug 5, 2024

@angus-g merge?

@angus-g angus-g merged commit afca0c1 into master Aug 5, 2024
8 checks passed
@angus-g angus-g deleted the angus-g/warnings branch August 5, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Database module captures all warnings
3 participants