NO-TICKET: Expose 'informational' as part of the AlertVariation type #3301
+4
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using Design System types, directly, in a project, the AlertVariation type is missing the string for the default Alert style, which is "informational," according to the docs. This update just adds that string to the union, but excludes it from the prop typing, since it's the default.
We are passing this detail via Adobe Analytics, so would like to have the "informational" typing exposed.
How to test
There is no impact to the use of the component. When built, a project that imports
AlertVariation
from Design System types should see "informational" as one of the options (in our case, for analytics purposes).Checklist
[WNMGDS-####] Title
or [NO-TICKET] if this is unticketed work.Type
(only one) label for this PR, if it is a breaking change, label should only beType: Breaking
Impacts
, multiple can be selected.If this is a change to design:
If this is a change to code:
yarn test:unit:update
) and browser-test snapshots (yarn test:browser:update
)If this is a change to documentation: