cli BUGFIX avoid read on -1 in linenoise

CESNET · Dec 4, 2024 · 4cddd92 · 4cddd92
1 parent 0fab177
commit 4cddd92
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/cli/linenoise/linenoise.c b/cli/linenoise/linenoise.c
@@ -1114,11 +1114,14 @@ void linenoiseEditDeletePrevWord(struct linenoiseState *l) {
  * STDIN_FILENO and STDOUT_FILENO.
  */
 int linenoiseEditStart(struct linenoiseState *l, int stdin_fd, int stdout_fd, char *buf, size_t buflen, const char *prompt) {
+    if (stdin_fd == -1) stdin_fd = STDIN_FILENO;
+    if (stdout_fd == -1) stdout_fd = STDOUT_FILENO;
+
     /* Populate the linenoise state that we pass to functions implementing
      * specific editing functionalities. */
     l->in_completion = 0;
-    l->ifd = stdin_fd != -1 ? stdin_fd : STDIN_FILENO;
-    l->ofd = stdout_fd != -1 ? stdout_fd : STDOUT_FILENO;
+    l->ifd = stdin_fd;
+    l->ofd = stdout_fd;
     l->buf = buf;
     l->buflen = buflen;
     l->prompt = prompt;