Changes for Elasticsearch 8 #271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
other work in this commit:
split facet translation functionality into own method
basic code cleanup to match styleguide recommendations
v1.0 version sends facets with just key: value
v1.1 (future) will send key: { source: , num: }
backwards compatible:
- value_label deprecated but forwards input to new method
so apps that overrode the search result items or item
show metadata pages are OK largely
not so much backwards compatible:
- if entire files were overridden like facets and browse_facets
then instead of a num the app will display a hash
remaining code should be API agnostic as far as display and queries apps which have overwritten helpers may encounter errors
I dunno what I was thinking when I wrote this code, because looking at it today I couldn't figure out why I thought that was a good idea. Must have just not been paying attention. Also fixes comment which used the wrong value Robocop agrees that it is bad. https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Lint/CircularArgumentReference
it's an odd bug...considering we've used the paginator a lot but I suspect it was due to various parameters I was plugging in trying to get some deprecation warnings to show up in query.rb
matches up with each other for one thing, less confusing for another
keyword facets now returning with markup of this kind but without sanitize that is just being hidden
@page_facets exist when helper called by something connected to typical items#index action, but if other templates are using `value_label` / `metadata` etc, they may not have defined any @page_facets and in that case, the value should simply be returned as is
I'm guessing this was introduced here: 4079e00 but I am impressed we didn't notice until now
the issue was that if you had a 2 page search result, the second page was not displaying because the "last" page was not in the list of next pages, and the last page is also no longer available by default fixed by adding the total page number to the pages_next and make sure to display dots if there are more results after the current range max page
- ALL_LANGUAGES was not used in the application, but languages is so setting that config option instead - the setup generator was creating files like "en|es.yml" due to not splitting on the pipe separator, this behavior is fixed
other work in this commit:
split facet translation functionality into own method
basic code cleanup to match styleguide recommendations
v1.0 version sends facets with just key: value
v1.1 (future) will send key: { source: , num: }
backwards compatible:
- value_label deprecated but forwards input to new method
so apps that overrode the search result items or item
show metadata pages are OK largely
not so much backwards compatible:
- if entire files were overridden like facets and browse_facets
then instead of a num the app will display a hash
remaining code should be API agnostic as far as display and queries apps which have overwritten helpers may encounter errors
matches up with each other for one thing, less confusing for another
keyword facets now returning with markup of this kind but without sanitize that is just being hidden
|
cherry-picked the relevant commits into new_release_staging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #263, based on new release branch.