Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MSH-9 for OML messages to be consistent with the HL7 spec #1300

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

somesylvie
Copy link
Contributor

Update MSH-9 for OML messages to be consistent with the HL7 spec

While working on the RS integration tests, we noticed that our existing hl7 OML messages couldn't be parsed because MSH-9 was the wrong format. This PR updates the OML mapping to use the right format for MSH-9

Issue

#1255

Checklist

  • I have added tests to cover my changes

Note: You may remove items that are not applicable

Copy link

sonarqubecloud bot commented Sep 9, 2024

Copy link
Contributor

@saquino0827 saquino0827 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@somesylvie somesylvie merged commit 47b9743 into main Sep 11, 2024
16 checks passed
@somesylvie somesylvie deleted the fix-msh-9 branch September 11, 2024 16:53
tjohnson7021 pushed a commit that referenced this pull request Oct 17, 2024
* Update MSH-9 for OML messages to be consistent with the HL7 spec
* update unit test to check for correct OML event coding

---------

Co-authored-by: Basilio Bogado <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants