Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wastewater Model #49

Merged
merged 65 commits into from
Dec 11, 2024
Merged

Wastewater Model #49

merged 65 commits into from
Dec 11, 2024

Conversation

sbidari
Copy link
Collaborator

@sbidari sbidari commented Oct 11, 2024

This PR replicates the WWW model as implemented here.

---------------fixed-----------------------------------------------
There is one issue with using predictive methods, specifically for the observed hospital admissions. Currently, the posterior predictive distribution for observed_hospital_admissions does not extend beyond the available datapoints because of how it is defined in the model. This was done to account for possible differences in the length of reporting time for wastewater and hospital admissions data, following the approach in the stan code. I am not sure how to circumvent this issue for the pyrenew model and would love to hear ideas/suggestions.
@dylanhmorris @damonbayer @kaitejohnson

sbidari and others added 30 commits August 29, 2024 13:34
* use LocScaleParam for non centered parametrization

* Apply suggestions from code review

Co-authored-by: Dylan H. Morris <[email protected]>

---------

Co-authored-by: Dylan H. Morris <[email protected]>
@sbidari sbidari requested a review from damonbayer December 9, 2024 22:10
@damonbayer
Copy link
Collaborator

@sbidari Can you share the rendered qmd file somewhere for me to look at?

@damonbayer
Copy link
Collaborator

@sbidari I think we should also include an equivalent of demos/hosp_only_ww_model/model_comp.qmd so we can easily compare results to the stan model.

@sbidari
Copy link
Collaborator Author

sbidari commented Dec 10, 2024

@sbidari Can you share the rendered qmd file somewhere for me to look at?

Rendered qmd files here https://cdc.sharepoint.com/:f:/r/teams/CenterforForecastingandOutbreakAnalytics/Shared%20Documents/General/02%20-%20Predict/Real%20Time%20Monitoring%20(RTM)%20Branch/Short%20Term%20Forecasts/PyRenew%20Wasewater%20Model?csf=1&web=1&e=3Y4JuM

@damonbayer damonbayer self-requested a review December 11, 2024 17:14
Copy link
Collaborator

@damonbayer damonbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this runs and produces plausible results, I am going to merge to main now. I will open an issue for further improvements and evaluation to be done next year.

@damonbayer damonbayer enabled auto-merge (squash) December 11, 2024 17:18
@damonbayer damonbayer merged commit 10c806b into main Dec 11, 2024
9 checks passed
@damonbayer damonbayer deleted the site_level_dynamics_ref_subpop branch December 11, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants