wastewater observation process #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-in-pyrenew_hew_modelpy
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #310 +/- ##
==========================================
- Coverage 24.72% 23.94% -0.79%
==========================================
Files 22 21 -1
Lines 1638 1679 +41
==========================================
- Hits 405 402 -3
- Misses 1233 1277 +44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
A few comments/questions/suggestions, all fairly minor. Thanks, @sbidari!
…s-in-pyrenew_hew_modelpy
…w_hew_modelpy' of https://github.com/CDCgov/pyrenew-hew into 300-update-wastewaterobservationprocess-class-in-pyrenew_hew_modelpy
Co-authored-by: Dylan H. Morris <[email protected]>
…w_hew_modelpy' of https://github.com/CDCgov/pyrenew-hew into 300-update-wastewaterobservationprocess-class-in-pyrenew_hew_modelpy
dylanhmorris
approved these changes
Jan 29, 2025
Thanks @dylanhmorris. The suggestions seem reasonable, will change these and merge. |
Co-authored-by: Dylan H. Morris <[email protected]>
sbidari
deleted the
300-update-wastewaterobservationprocess-class-in-pyrenew_hew_modelpy
branch
damonbayer
added a commit
that referenced
this pull request
Jan 29, 2025
commit 39c003d Author: Subekshya Bidari <[email protected]> Date: Wed Jan 29 16:20:53 2025 -0500 wastewater observation process (#310) * add ww obs process * pre-commit * update build pyrenew model * fix output assignment in test latent infection process * include some rvs as placeholders * change prior * use priors from stan model * fix typo * move data args to sample method * pre-commit * update prod_priors.py * sync * update generate_predictive.py * pre-commit * move model constant to prior as per dhm suggestion * make get_viral_trajectory a class method * remove outdated call to utils * output assignment * state -> population * code review suggestions * code review suggestions * update distributional variable sample call * Apply suggestions from code review Co-authored-by: Dylan H. Morris <[email protected]> * pre-commit * Apply suggestions from code review Co-authored-by: Dylan H. Morris <[email protected]> --------- Co-authored-by: Dylan H. Morris <[email protected]> commit df3648d Author: Dylan H. Morris <[email protected]> Date: Tue Jan 28 17:20:34 2025 +0000 Improvements and bug fixes for epiweekly other hubverse tables and plots (#312)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds code for the wastewater observation process in
pyrenew_hew_model.py.It does not add wastewater data to
pyrenew_hew_data.py.