Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point at prod_priors.py in end-to-end test #279

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Point at prod_priors.py in end-to-end test #279

merged 1 commit into from
Jan 7, 2025

Conversation

dylanhmorris
Copy link
Contributor

this means the test_output directory can be deleted, as it only contained priors.py.

@dylanhmorris dylanhmorris linked an issue Jan 7, 2025 that may be closed by this pull request
End to end test should use prod_priors.py #278
Closed
@codecov Codecov
Copy link

codecov bot commented Jan 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.48%. Comparing base (1a5b8bd) to head (78dc1a7).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #279   +/-   ##
=======================================
  Coverage   16.48%   16.48%           
=======================================
  Files          21       21           
  Lines        1480     1480           
=======================================
  Hits          244      244           
  Misses       1236     1236
Flag Coverage Δ
hewr 47.68% <ø> (ø)
pipelines 0.00% <ø> (ø)
pyrenew_hew 1.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

damonbayer
damonbayer approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@damonbayer damonbayer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, assuming the tests pass with the priors file deleted.

@dylanhmorris dylanhmorris merged commit 1fb4c2e into main Jan 7, 2025
15 checks passed
@dylanhmorris dylanhmorris deleted the 278-end-to-end-test-should-use-prod_priorspy branch January 7, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damonbayer damonbayer damonbayer approved these changes

@sbidari sbidari Awaiting requested review from sbidari sbidari is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

End to end test should use prod_priors.py
2 participants
@dylanhmorris @damonbayer