-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 110: Add epiweekly fits and scoring #159
Conversation
Added a step to convert daily resolved data to epiweekly cf |
Modified |
Added scoring on epiweekly scale for Dates for the week are supplied by more forecasttools helpers. No other changes were need because the scoring is flexible enough to ingest this. |
This is ready for review now. Note that the plotting is unchanged and the ultimate scoring end product is both:
The collate functions seem to be currently broken, but I'm interpreting that as a new issue. |
Also note that this PR has inherited the failing CI from #160 |
@SamuelBrand1 Since we are making even more model results and anticipate adding PyRenew-EW to the workflow soon, I would really like to push toward #101. Could the fable-related parts of that issue be accomplished in this PR (i.e. let's store all the results from these time series models in a |
…s() function to timeseries_forecasts() for consistency with script name
…neration in forecast_state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing that would necessarily prevent a merge, but I had lots of comments and questions.
I've closed the comments marked Outdated and we are onto our last few. I think @damonbayer remains the reviewer here because this PR is a mix of me and @dylanhmorris |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dylanhmorris This PR has my tentative approval. Please respond to (or make changes based on) the remaining comments before merging.
…into epiweekly-fits
This PR closes #110 .
NB this PR uses
forecasttools
functions, in particulardaily_to_epiweekly
. Very handy.The goal is to compare the epiweekly forecasts of baseline models (which are fitted to epiweekly data) to the epiweekly grouped forecasts from
pyrenew_hew
.The daily analysis is unaffected; that is baseline models are still run for daily reporting as well.
Tasks to contribute
Testing
At each step the test mode pipeline is run to check for failure or breaking changes.