Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code to condition comparison endpoint #17009

Merged
merged 12 commits into from
Jan 14, 2025
Merged

Conversation

the-andrew
Copy link
Collaborator

Added /api/sender/conditionCode/comparison endpoint in new SenderFunction.kt file
Tried to add some unit tests based on templates from existing tests from ReportFunction. Can adjust or add as needed.

Test Steps:

  1. Include steps to test these changes

Changes

  • New endpoint: /api/sender/conditionCode/comparison
  • New SenderFunction.kt file
  • New SenderFunctionTest.kt file

Checklist

Testing

  • Tested locally?
  • Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • (For Changes to /frontend-react/...) Ran npm run lint:write?
  • Added tests?

Process

  • Are there licensing issues with any new dependencies introduced?
  • Includes a summary of what a code reviewer should test/verify?
  • Updated the release notes?
  • Database changes are submitted as a separate PR?
  • DevOps team has been notified if PR requires ops support?

Linked Issues

To Be Done

Create GitHub issues to track the work remaining, if any

  • #issue

Specific Security-related subjects a reviewer should pay specific attention to

  • Does this PR introduce new endpoints?
    • new endpoint A
    • new endpoint B
  • Does this PR include changes in authentication and/or authorization of existing endpoints?
  • Does this change introduce new dependencies that need vetting?
  • Does this change require changes to our infrastructure?
  • Does logging contain sensitive data?
  • Does this PR include or remove any sensitive information itself?

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

  • What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated
    • Spoofing (faking authenticity)
      • Threat T, which could be achieved by A, is mitigated by M
    • Tampering (influence or sabotage the integrity of information, data, or system)
    • Repudiation (the ability to dispute the origin or originator of an action)
    • Information disclosure (data made available to entities who should not have it)
    • Denial of service (make a resource unavailable)
    • Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)
  • Have you ensured logging does not contain sensitive data?
  • Have you received any additional approvals needed for this change?

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Test Results

1 271 tests  +6   1 267 ✅ +6   7m 23s ⏱️ -1s
  165 suites +1       4 💤 ±0 
  165 files   +1       0 ❌ ±0 

Results for commit d77cb2d. ± Comparison against base commit fbede22.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Integration Test Results

 60 files   60 suites   42m 38s ⏱️
428 tests 418 ✅ 10 💤 0 ❌
431 runs  421 ✅ 10 💤 0 ❌

Results for commit d77cb2d.

♻️ This comment has been updated with latest results.

@the-andrew the-andrew marked this pull request as draft January 9, 2025 23:11
@the-andrew the-andrew marked this pull request as ready for review January 13, 2025 19:10
Copy link
Collaborator

@victor-chaparro victor-chaparro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
4.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@the-andrew the-andrew merged commit 5a7a1e3 into main Jan 14, 2025
24 of 25 checks passed
@the-andrew the-andrew deleted the feature/engagement/apham/16852 branch January 14, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement code to condition comparison API
2 participants