Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding documentation for Aspen Configuration Panel #1243

Merged
merged 6 commits into from
Oct 1, 2024

Conversation

sotorrio1
Copy link
Member

@sotorrio1 sotorrio1 commented Sep 24, 2024

Fixes/Addresses:

Adding documentation related to recently merged PR #1239

Summary/Motivation:

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the copyright and license terms described in the LICENSE.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@sotorrio1 sotorrio1 self-assigned this Sep 24, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.75%. Comparing base (0db11e9) to head (8f505da).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1243      +/-   ##
==========================================
- Coverage   38.78%   38.75%   -0.03%     
==========================================
  Files         164      164              
  Lines       37139    37139              
  Branches     6164     6164              
==========================================
- Hits        14403    14392      -11     
- Misses      21597    21611      +14     
+ Partials     1139     1136       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sotorrio1 sotorrio1 linked an issue Sep 25, 2024 that may be closed by this pull request
@sotorrio1 sotorrio1 added Flowsheet Issues related to setting up, & running process models for simulation in the Flowsheet tab Documentation Update existing and adding new documents and tutorials labels Sep 30, 2024
Copy link
Member

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Oct 1, 2024
@ksbeattie ksbeattie merged commit 2e54f98 into CCSI-Toolset:master Oct 1, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Update existing and adding new documents and tutorials Flowsheet Issues related to setting up, & running process models for simulation in the Flowsheet tab Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration Panel: Add Timeouts for AspenConsumer
2 participants