-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add first implementation of scaling functions #1197
base: master
Are you sure you want to change the base?
Conversation
return result | ||
|
||
|
||
# fix expected values in test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there code missing after this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing that out, the comment was a note to revise the expected values in test_scaling.py, and the issue has been resolved.
def unscale_log(array_in, lo, hi): | ||
result = lo * np.power(hi / lo, array_in) | ||
|
||
# result = ((np.log10(array_in) - np.log10(lo)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove commented code, if it's not required for anything (same for other commented code in the rest of this file).
return result | ||
|
||
|
||
class BaseScaler: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may be misunderstanding the usage of the annotations here, but what is the outcome of this class? It seems that arrays that are transformed will raise exceptions for any input.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add a comment to explain the purpose of the BaseScaler class; transform() and inverse_transform() should be implemented by the derived classes, so it raises an error if called from the base class.
This is affected by the Tensorflow version issues that are being worked on in #1223. This should be considered on hold until those issues have been resolved. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1197 +/- ##
==========================================
+ Coverage 38.81% 38.96% +0.14%
==========================================
Files 164 165 +1
Lines 37048 37178 +130
Branches 6153 6159 +6
==========================================
+ Hits 14382 14486 +104
- Misses 21528 21553 +25
- Partials 1138 1139 +1 ☔ View full report in Codecov by Sentry. |
Fixes/Addresses:
#1196
Summary/Motivation:
Adding initial implementation of scaling functions for ML/AI plugin, with tests included.
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: