Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CI static check to enforce consistent import order #1170

Merged
merged 10 commits into from
Dec 13, 2023

Conversation

lbianchi-lbl
Copy link
Contributor

Resolves (partially) #1162

Changes proposed in this PR:

  • Enable wrong-import-order Pylint check

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the copyright and license terms described in the LICENSE.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (f0cf1c3) 38.54% compared to head (0f8146a) 38.52%.

Files Patch % Lines
foqus_lib/gui/model/dmfUploadDialog.py 0.00% 9 Missing ⚠️
...qus_lib/framework/solventfit/SolventFit_testing.py 0.00% 6 Missing ⚠️
foqus_lib/foqus.py 72.72% 3 Missing ⚠️
foqus_lib/gui/sinter/sinter_config.py 0.00% 3 Missing ⚠️
foqus_lib/framework/optimizer/OptSNOBFIT.py 0.00% 2 Missing ⚠️
foqus_lib/framework/pymodel/heat_integration.py 0.00% 2 Missing ⚠️
foqus_lib/framework/surrogate/foqusALAMOClient.py 0.00% 2 Missing ⚠️
foqus_lib/framework/graph/heatIntegration.py 0.00% 1 Missing ⚠️
foqus_lib/framework/optimizer/SM_Optimizer.py 92.85% 1 Missing ⚠️
foqus_lib/framework/optimizer/Snobfit.py 87.50% 1 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1170      +/-   ##
==========================================
- Coverage   38.54%   38.52%   -0.02%     
==========================================
  Files         163      163              
  Lines       36880    36852      -28     
  Branches     5995     5994       -1     
==========================================
- Hits        14217    14199      -18     
+ Misses      21557    21544      -13     
- Partials     1106     1109       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Oct 3, 2023
@lbianchi-lbl lbianchi-lbl changed the title Enable import-related CI static checks Enable CI static check to enforce consistent import order Dec 13, 2023
@lbianchi-lbl lbianchi-lbl marked this pull request as ready for review December 13, 2023 15:45
@lbianchi-lbl lbianchi-lbl merged commit 6694f80 into CCSI-Toolset:master Dec 13, 2023
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants