Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODoE: Error handling when results are None #1159

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

sotorrio1
Copy link
Member

Fixes/Addresses:

Addresses issue #1126

Summary/Motivation:

Although issue #1126 seems to be solved, we're proposing a different way to handle errors in the case the ODoE results (best_indices and best_optval) are None.

Changes proposed in this PR:

  • check if best_indices is None and modify resultMessage accordingly
  • check if best_optval is None and modify resultMessage accordingly

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the copyright and license terms described in the LICENSE.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@sotorrio1 sotorrio1 self-assigned this Aug 23, 2023
@sotorrio1 sotorrio1 added FOQUS GUI Issues related to information displayed on the GUI, or broken buttons ODoE Robust Optimality-base Design of Experiments labels Aug 23, 2023
@sotorrio1 sotorrio1 linked an issue Aug 23, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch has no changes to coverable lines.

Files Changed Coverage
foqus_lib/gui/sdoe/sdoeSetupFrame.py 0.00%

📢 Thoughts on this report? Let us know!.

@sotorrio1 sotorrio1 marked this pull request as ready for review August 23, 2023 22:23
Copy link
Member

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. At least this doesn't throw an exception and shows the user that something has gone wrong.

@ksbeattie ksbeattie merged commit baa13c8 into CCSI-Toolset:master Sep 12, 2023
14 of 16 checks passed
@sotorrio1 sotorrio1 deleted the issue-1126 branch September 27, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FOQUS GUI Issues related to information displayed on the GUI, or broken buttons ODoE Robust Optimality-base Design of Experiments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ODoE Tutorial Issue
2 participants