Some updates to the pod class #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuanMPhm
reviewed
Oct 8, 2024
I updated get_service_unit so it's not a static method anhmore. I don't have to pass any arguments to it anymore. I can simply call it on the pod object. That change then broke write_metrics_by_pod because it was making a call to get_service_unit, so I updated that method to use the new pod class. In that process I ended up writing a method to generate the pod metric rows so now write_metrics_by_pod uses the pod class for generating the report. I decided to remove certain columns for this report, specifically the coldfront attributes because they are not particularly useful in a pod report.
They were made a part of invoice.py, so this commit removes then from utils.py and updates any references (mainly tests) to get them from invoice.py. Additionally removes some unused imports from utils.py
I switched to utilizing datetime.UTC when converting from epoch time to datetime since the older way is now deprecated.
naved001
force-pushed
the
refactor/invoice_class_2
branch
from
4f622d7 to
5419778
Compare
|
@QuanMPhm I have addressed your comments. |
QuanMPhm
approved these changes
Oct 9, 2024
knikolla
reviewed
Oct 16, 2024
knikolla
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit messages have more detail. The first commit updates
get_service_unitandwrite_metrics_by_pod. The second commit does a clean up of things.