Create a prometheus client #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naved001
force-pushed
the
refactor/prometheus_client
branch
2 times, most recently
from
fd05bb9 to
d587557
Compare
knikolla
requested changes
Sep 23, 2024
|
|
||
| class PrometheusClient: | ||
| def __init__(self, prometheus_url: str, token: str, step_min: int=15): | ||
| self.proemtheus_url = prometheus_url |
There was a problem hiding this comment.
good catch! thanks.
Part of the refactoring to organize the codebase. This moves the methods to talk to prometheus into a class in its own module. The unit tests have also been moved to a separate file. closes CCI-MOC#69
naved001
force-pushed
the
refactor/prometheus_client
branch
from
d587557 to
49ba5d6
Compare
knikolla
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the refactoring to organize the codebase. This moves the methods to talk to prometheus into a class in its own module.
The unit tests have also been moved to a separate file.
closes #69