Update offer claim UI to reflect default times (start: now, max: 1 day) #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheldor1510
reviewed
Jan 16, 2025
There was a problem hiding this comment.
Why are all the input fields in this form required and not conditionally ng-required like they were before? I can't submit the form to claim the offer even when the default times are filled as the claim button is disabled. It seems the input fields are not recognizing the default values.
|
@skanthed Looks like there's a small bug with the form fields, I think I can fix the error that's coming right now - do you mind if I finish the PR? |
|
@sheldor1510 I started working on something else. And I totally forgot to update this. I have the code in my repo but I need to test it. If you want to finish it no issues. It will be great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.