Fix bug with claiming offer #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DanNiESh could you take a look at this when you have a moment? Thanks! |
If an offer is claimed for its entire duration, and someone else tries to claim the offer without specifying a start/end time, then the db function will think that the next available end time is before the current time. This fixes that issue, as well as renaming the db function to be clearer regarding its function.
tzumainn
force-pushed
the
fix-offer-claim
branch
from
316a089 to
3068eaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an offer is claimed for its entire duration, and someone else tries to claim the offer without specifying a start/end time, then the db function will think that the next available end time is before the current time. This fixes that issue, as well as renaming the db function to be clearer regarding its function.