Fix some tiny issues #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can use multibyte characters(eg. Japanese, Chinese and Hangul)
ume365
commented
Nov 29, 2019
| private IntPtr Prepare (string query) | ||
| { | ||
| IntPtr stmHandle; | ||
|
|
||
| if (sqlite3_prepare_v2 (_connection, query, query.Length, out stmHandle, IntPtr.Zero) != SQLITE_OK) { | ||
| int byteCnt= System.Text.Encoding.GetEncoding("UTF-8").GetByteCount(query); |
There was a problem hiding this comment.
use query byte instead of query length for 3rd args of sqlite3_prepare_v2
ume365
commented
Nov 29, 2019
| WWW www = new WWW (sourcePath); | ||
| // Wait for download to complete - not pretty at all but easy hack for now | ||
| // Android | ||
| UnityWebRequest www = new UnityWebRequest(); |
There was a problem hiding this comment.
replace WWW class with UnityWebRequest class, because Unity team abolished WWW class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace WWW class with UnityWebRequest class.
Can use multibyte characters(eg. Japanese, Chinese and Hangul)