Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat[webapp][breakpoints]: ENG-7984 Add another breakpoint #3856

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat[webapp][breakpoints]: ENG-7984 Add another breakpoint #3856

wants to merge 3 commits into from
+43 −26

Conversation

midhunadarvin
Copy link
Contributor

Description

  • add xsmall breakpoints for gen1 react sdk

Link to JIRA ticket:
https://builder-io.atlassian.net/browse/ENG-7984

Loom
https://www.loom.com/share/f5f262080f7040f89eb976c5066dd237

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2025

⚠️ No Changeset found

Latest commit: 29edb4a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 24, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 29edb4a.

Command Status Duration Result
nx test @e2e/nextjs-sdk-next-app ✅ Succeeded 8m 31s View ↗
nx test @e2e/vue ✅ Succeeded 5m 44s View ↗
nx test @e2e/sveltekit ✅ Succeeded 5m 57s View ↗
nx test @e2e/qwik-city ✅ Succeeded 8m 12s View ↗
nx test @e2e/svelte ✅ Succeeded 5m 50s View ↗
nx test @e2e/nuxt ✅ Succeeded 7m 59s View ↗
nx test @e2e/solid-start ✅ Succeeded 5m 20s View ↗
nx test @e2e/react-sdk-next-14-app ✅ Succeeded 5m 43s View ↗
Additional runs (35) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-01-24 10:25:09 UTC

sanyamkamat
sanyamkamat reviewed Jan 24, 2025
View reviewed changes
packages/react/src/components/builder-block.component.tsx
@@ -181,7 +181,15 @@ export class BuilderBlock extends React.Component<
const reversedNames = sizeNames.slice().reverse();
const styles: any = {};
if (responsiveStyles) {
const contentHasXSmallBreakpoint = Boolean(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: we could avoid this flag and the check in the for loop later. That way we will treat xsmall as existing medium or small sizes.

sanyamkamat
sanyamkamat reviewed Jan 24, 2025
View reviewed changes
packages/react/src/constants/device-sizes.constant.ts
@@ -21,8 +21,8 @@ const sizes = {
max: 991,
},
large: {
min: 990,
default: 991,
min: 992,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the default large having bigger implications, we should avoid this change for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanyamkamat sanyamkamat sanyamkamat left review comments

@samijaber samijaber Awaiting requested review from samijaber

@sidmohanty11 sidmohanty11 Awaiting requested review from sidmohanty11

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@midhunadarvin @sanyamkamat