add support for binding responsive styles in gen1 react sdk

[steve8708]

currently gen2 SDKs support binding to responsive styles, like

{ bindings: { 'responsiveStyles.medium.color': 'state.foo'}

but not gen1, this fixes that

[changeset-bot]

🦋 Changeset detected

Latest commit: 2d0006a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@builder.io/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2d0006a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

🟥 Failed Commands
nx test @e2e/react-sdk-next-pages

✅ Successfully ran 38 targets

• nx test @e2e/nextjs-sdk-next-app
• nx test @e2e/nuxt
• nx test @e2e/qwik-city
• nx test @e2e/react-native
• nx test @e2e/svelte
• nx test @e2e/sveltekit
• nx test @e2e/vue
• nx test @e2e/react-sdk-next-app
• nx test @e2e/angular-ssr
• nx test @e2e/solid-start
• nx test @e2e/hydrogen
• nx test @e2e/gen1-react
• nx test @e2e/angular
• nx test @e2e/solid
• nx test @e2e/react
• nx test @e2e/remix
• nx test @e2e/gen1-remix
• nx test @snippet/react-native
• nx test @snippet/angular-ssr
• nx test @e2e/gen1-next
• nx test @snippet/angular
• nx test @snippet/react-sdk-next-app
• nx test @snippet/nextjs-sdk-next-app
• nx test @snippet/qwik-city
• nx test @snippet/sveltekit
• nx test @snippet/hydrogen
• nx test @snippet/svelte
• nx test @snippet/react-sdk-next-pages
• nx test @snippet/nuxt
• nx test @snippet/solid
• nx test @snippet/vue
• nx test @snippet/react
• nx test @snippet/gen1-next
• nx test @snippet/gen1-remix
• nx test @snippet/gen1-react
• nx test @builder.io/sdks
• nx typecheck @builder.io/sdks
• nx build @builder.io/sdk

---

Sent with 💌 from NxCloud.

[samijaber]

oh, this logic fixes responsive styles? how are they broken exactly? in SSR?

You initially described this same code as solving SSR of styles, but when Clyde added tests it still didn't address that so he made a different change: #3563

[steve8708]

Where was SSR mentioned? This ( #3485 ) was the original PR, I didn't realize we removed this code that I added (was supposed to get in pre launch). The Pr title and description were:

​add support for responsive styles in gen1 react sdk and memoize processBlock ​we don't use the post-processed responsiveStyles object that bindings influence, but instead the preprocessed one ​gen2 supports this, but not gen1

maybe just miscommunication somewhere?

[samijaber]

maybe just miscommunication somewhere?

Seems to be the case. It looks like i conflated two gen1 style issues that you pointed out around the same time (binding responsible styles, and SSR'ing styles).

Sorry this didn't make it in sooner.

[steve8708]

all good - best time to plant a tree is 10 years ago, second best time is today! thanks for the quick review