feat: Add zelki's builder profile route #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
phipsae
requested changes
Jan 19, 2025
There was a problem hiding this comment.
Very nice personal page, thanks a lot! The eye is funny :)
Just a little general thing for PR descriptions: for the next one, it would be nice if you could add a screenshot of what you implement (for more complex stuff a video comes handy).
And below just two little comments.
packages/nextjs/app/builders/0x31973c1799C889A03f9ce9EA468c3ceF26F01169/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0x31973c1799C889A03f9ce9EA468c3ceF26F01169/page.tsx
Outdated
Show resolved
Hide resolved
phipsae
approved these changes
Jan 21, 2025
|
Nice page, thanks! Lets merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
My entry for the #11 issue. The issue seems to be closed so I hope I'm still on time to complete it.
Additional Information
Related Issues
#11
Your ENS/address: zelki.eth