Add Wilfred profile #34

Wilfred007 · 2025-01-15T17:18:00Z

Description

I've made all the changes and updates

Added links to my socials
Spaced the socials icons
Replaced the screenshot
Changed the image name to my EVM address
Moved static data outside React component
I fixed nextjs image error
I moved the ADDRESS below the import statements
I've fixed the missing props error

Additional Information

I have read the contributing docs (if this is your first contribution)
This is not a duplicate of any existing pull request

Your ENS/address: 0x2aA2f7090f0ADD72B2d50386CdDE97CE27898287

vercel · 2025-01-15T17:18:04Z

@Wilfred007 is attempting to deploy a commit to the BuidlGuidl Team on Vercel.

A member of the Team first needs to authorize it.

vercel · 2025-01-15T19:50:24Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
batch12.buidlguidl.com	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 30, 2025 0:39am

derrekcoleman

Thank you for your PR, Wildfred007! And welcome to the Batch12 repo :)

Thank you for including a screenshot of your PR 📷

Please also add a few summary sentences to your PR message describing what this PR adds (your page, an overview of sections, keep it high-level).
Also read the Contributing docs, then check both boxes in the PR message to acknowledge them.

I look forward to buidling with you!

packages/nextjs/app/builders/0x2aA2f7090f0ADD72B2d50386CdDE97CE27898287/page.tsx

Wilfred007 · 2025-01-16T05:57:15Z

I've made all the changes and updates

Added links to my socials
Spaced the socials icons
Replaced the screenshot
Changed the image name to my EVM address

@derrekcoleman

derrekcoleman

Thanks for implementing most of my suggestions, @Wilfred007! There are a couple last things I'd like you to practice in the spirit of building those good git habits 🏋️

It's common to respond to the comment with a suggested change either with a comment of your own such as "Sounds good, will do", a clarifying question, or at least an emoji reaction to acknowledge you saw it.
However you respond, please also click Resolve conversation for any comments that you addressed in your recent commits. That's another way to help the reviewer know you incorporated their feedback.
Like I said before, please also add a few summary sentences to your original PR message describing what this PR adds (your page, an overview of sections, keep it high-level).
Whenever you update the PR, it is recommended to update the first message's screenshot as well so anyone coming to the discussion has an up-to-date picture of the changes you made.
Please address this previous comment. If you aren't sure what I mean, you can always ask :)

packages/nextjs/app/builders/0x2aA2f7090f0ADD72B2d50386CdDE97CE27898287/page.tsx

derrekcoleman

One last change, following up on this request from last week. lmk if you aren't sure what I mean

packages/nextjs/app/builders/0x2aA2f7090f0ADD72B2d50386CdDE97CE27898287/page.tsx

phipsae

Sorry for the wait.

Below you'll find two tiny comments and then we finally merge.

Next time you implement your changes, you can request a review from us directly on GitHub. Start by leaving a quick comment to let us know you've completed the changes. Then, in the top-right corner of the page, locate the reviewer box and click on the 🔄 icon to request a review.

Thank you!

packages/nextjs/app/builders/0x2aA2f7090f0ADD72B2d50386CdDE97CE27898287/page.tsx

phipsae · 2025-01-28T08:43:35Z

packages/nextjs/app/builders/0x2aA2f7090f0ADD72B2d50386CdDE97CE27898287/page.tsx

+            <Image
+              src="/0x2aA2f7090f0ADD72B2d50386CdDE97CE27898287.jpg"
+              alt="0x2aA2f7090f0ADD72B2d50386CdDE97CE27898287"
+              layout="fill"
+              className="rounded-full ring-4 ring-blue-500"
+            />


As a good practice it is recommended to check to console for any warnings/errors.
It shows me the following:

Pls make sure to fix them.

This is still outstanding

derrekcoleman

Thanks for addressing the Image prop issue, @Wilfred007! Please take a look at the other comment, related to factoring all of your constants outside of the NextPage component - you still have an ADDRESS in the middle that would be more organized if it was just below your import statements.

Wilfred007 · 2025-01-29T18:12:46Z

Thanks for addressing the Image prop issue, @Wilfred007! Please take a look at the other comment, related to factoring all of your constants outside of the NextPage component - you still have an ADDRESS in the middle that would be more organized if it was just below your import statements.

Thank you for your patience, I've made the changes

phipsae · 2025-01-29T19:14:55Z

@Wilfred007, please see my comments above. I’m still seeing the warning in the console. In general, when requesting a review, please ensure that all previous points have been addressed and check the console for any warnings/erros. Otherwise, it becomes repetitive to highlight the same issues multiple times.

phipsae · 2025-01-30T07:50:51Z

@Wilfred007 why do you request a review, when you haven't made any chances? I don't see any new commits...

This is the error it get still shown to me. If you scroll up, I already mentioned it in the unresolved conversation.

Pls fix it, thank!

Wilfred007 · 2025-01-30T12:40:41Z

@Wilfred007 why do you request a review, when you haven't made any chances? I don't see any new commits...

This is the error it get still shown to me. If you scroll up, I already mentioned it in the unresolved conversation.

Pls fix it, thank!

Thank you for your patience, Ive fixed the missing props error, but I'm seeing a lit is in dev mode warning is that something I need to fix too because I've not seen this warning before. Can you help? Thank you

derrekcoleman · 2025-01-30T17:40:02Z

Thank you for your patience, Ive fixed the missing props error, but I'm seeing a lit is in dev mode warning is that something I need to fix too because I've not seen this warning before. Can you help? Thank you

That error does not seem to happen in production, which is consistent with it being a "dev mode" (i.e. local testing) warning. Have you searched the error on the internet or asked an AI what it might mean and whether any changes might be needed? Those are steps I sometimes take when I'm facing a new, unfamiliar error.

Wilfred007 · 2025-01-30T22:59:01Z

Thank you for your patience, Ive fixed the missing props error, but I'm seeing a lit is in dev mode warning is that something I need to fix too because I've not seen this warning before. Can you help? Thank you

That error does not seem to happen in production, which is consistent with it being a "dev mode" (i.e. local testing) warning. Have you searched the error on the internet or asked an AI what it might mean and whether any changes might be needed? Those are steps I sometimes take when I'm facing a new, unfamiliar error.

I did but can't seem to find a direct solution, it's saying it might not be something serious in production. Is it possible for us to move on with this?

derrekcoleman

Thanks for taking the time to implement our suggestions, @Wilfred007! Your git-fu skills are stronger for it 🥷

Wilfred007 added 3 commits January 15, 2025 17:09

profile Wilfred

8745147

Wilfred profile

c7515f2

added address component

e5c5ad9

vercel bot deployed to Preview January 15, 2025 19:53 View deployment

derrekcoleman requested changes Jan 15, 2025

View reviewed changes

derrekcoleman assigned Wilfred007 Jan 15, 2025

Wilfred profile page edits and correction

dd09526

vercel bot deployed to Preview January 16, 2025 19:21 View deployment

derrekcoleman requested changes Jan 16, 2025

View reviewed changes

packages/nextjs/app/builders/0x2aA2f7090f0ADD72B2d50386CdDE97CE27898287/page.tsx Outdated Show resolved Hide resolved

packages/nextjs/app/builders/0x2aA2f7090f0ADD72B2d50386CdDE97CE27898287/page.tsx Outdated Show resolved Hide resolved

fixed component

608016e

vercel bot deployed to Preview January 18, 2025 13:59 View deployment

phipsae requested a review from derrekcoleman January 21, 2025 13:22

derrekcoleman requested changes Jan 24, 2025

View reviewed changes

packages/nextjs/app/builders/0x2aA2f7090f0ADD72B2d50386CdDE97CE27898287/page.tsx Outdated Show resolved Hide resolved

Wilfred007 added 2 commits January 25, 2025 04:30

fixed: moved static data outside the React component

2c7ec06

fixed: Moved static data abive the return statement

44c7ee6

vercel bot deployed to Preview January 25, 2025 04:34 View deployment

vercel bot deployed to Preview January 25, 2025 04:37 View deployment

phipsae requested a review from derrekcoleman January 28, 2025 08:12

phipsae requested changes Jan 28, 2025

View reviewed changes

fixed nextjs image error

e457149

vercel bot deployed to Preview January 28, 2025 12:30 View deployment

Wilfred007 requested a review from phipsae January 28, 2025 12:34

derrekcoleman requested changes Jan 28, 2025

View reviewed changes

Wilfred007 requested a review from derrekcoleman January 29, 2025 18:09

moved address

48030fb

vercel bot deployed to Preview January 29, 2025 18:14 View deployment

fixed console error

65e6185

vercel bot deployed to Preview January 30, 2025 12:39 View deployment

derrekcoleman approved these changes Jan 30, 2025

View reviewed changes

derrekcoleman merged commit da6fa7c into BuidlGuidl:main Jan 30, 2025
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Wilfred profile #34

Add Wilfred profile #34

Wilfred007 commented Jan 15, 2025 •

edited

Loading

vercel bot commented Jan 15, 2025

vercel bot commented Jan 15, 2025 •

edited

Loading

derrekcoleman left a comment

Wilfred007 commented Jan 16, 2025 •

edited

Loading

derrekcoleman left a comment

derrekcoleman left a comment

phipsae left a comment •

edited

Loading

phipsae Jan 28, 2025

phipsae Jan 29, 2025

phipsae Jan 29, 2025

derrekcoleman left a comment

Wilfred007 commented Jan 29, 2025 •

edited

Loading

phipsae commented Jan 29, 2025 •

edited

Loading

phipsae commented Jan 30, 2025

Wilfred007 commented Jan 30, 2025

derrekcoleman commented Jan 30, 2025

Wilfred007 commented Jan 30, 2025

derrekcoleman left a comment

Add Wilfred profile #34

Add Wilfred profile #34

Conversation

Wilfred007 commented Jan 15, 2025 • edited Loading

Description

Additional Information

vercel bot commented Jan 15, 2025

vercel bot commented Jan 15, 2025 • edited Loading

derrekcoleman left a comment

Choose a reason for hiding this comment

Wilfred007 commented Jan 16, 2025 • edited Loading

derrekcoleman left a comment

Choose a reason for hiding this comment

derrekcoleman left a comment

Choose a reason for hiding this comment

phipsae left a comment • edited Loading

Choose a reason for hiding this comment

phipsae Jan 28, 2025

Choose a reason for hiding this comment

phipsae Jan 29, 2025

Choose a reason for hiding this comment

phipsae Jan 29, 2025

Choose a reason for hiding this comment

derrekcoleman left a comment

Choose a reason for hiding this comment

Wilfred007 commented Jan 29, 2025 • edited Loading

phipsae commented Jan 29, 2025 • edited Loading

phipsae commented Jan 30, 2025

Wilfred007 commented Jan 30, 2025

derrekcoleman commented Jan 30, 2025

Wilfred007 commented Jan 30, 2025

derrekcoleman left a comment

Choose a reason for hiding this comment

Wilfred007 commented Jan 15, 2025 •

edited

Loading

vercel bot commented Jan 15, 2025 •

edited

Loading

Wilfred007 commented Jan 16, 2025 •

edited

Loading

phipsae left a comment •

edited

Loading

Wilfred007 commented Jan 29, 2025 •

edited

Loading

phipsae commented Jan 29, 2025 •

edited

Loading