Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrongly removing valueType=binding #14927

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented Oct 31, 2024

Description

Fixing issue where the binding type was removed, displaying base64 values

Before

Screen.Recording.2024-10-31.at.11.08.15.mov

After

Screen.Recording.2024-10-31.at.11.17.19.mov

Copy link

linear bot commented Oct 31, 2024

Copy link

qa-wolf bot commented Oct 31, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added the firestorm Data/Infra/Revenue Team label Oct 31, 2024
@adrinr adrinr marked this pull request as ready for review October 31, 2024 10:18
Copy link
Contributor

@deanhannigan deanhannigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adrinr adrinr merged commit acb5d27 into feature/automation-branching-ux Oct 31, 2024
12 checks passed
@adrinr adrinr deleted the budi-8810-automation-branches-condition-base64-encoding-gets-displayed branch October 31, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
firestorm Data/Infra/Revenue Team size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants