Throw an error when attempting to bulkImport a relationship field into an internal table. #14925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o an internal table. It doesn't work yet.
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
mike12345567
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This cost myself and @mike12345567 an hour or so today. If you bulk import a relationship field into an internal table it does entirely the wrong thing. It should just be an error for now, to avoid confusion in future.
This shouldn't be reachable behaviour in the UI, because the CSV that gets important is first sent to a validation endpoint that strips out relationship fields. This is mostly to help idiots like me write tests without wasting time.