-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make queryUI
on ViewV2
something you can write on its own, and query
gets filled in for you
#14818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
adrinr
reviewed
Oct 22, 2024
…budibase into queryui-default
…budibase into queryui-default
mike12345567
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - very nice work, great to get all the tests updated as well!
adrinr
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is on request of @aptkingston, it makes it such that the various view APIs allow the frontend to only work with
queryUI
and can ignorequery
.Here's broadly what's happening:
queryUI
it will generatequery
for you (regardless what you specify forquery
, it will get overwritten becausequeryUI
is the source of truth).query
but noqueryUI
,queryUI
will get generated fromquery
*.*This only happens if
query
is of typeLegacyFilter[]
, which is true of allViewV2
in prod on Budicloud today (we checked). When we convertqueryUI
toquery
, we don't convert to aLegacyFilter[]
but instead to aSearchFilters
. There's currently no function to convert betweenSearchFilters
andUISearchFilter
(renamed fromSearchFilterGroup
) because it's technically lossy, and in theory we don't have to because from now on the frontend will always setqueryUI
.I'm sorry for how confusing this all is. There's a lot of history around this part of the codebase and I'm doing the best I can to slot in new requirements to an already complex part of the code.
Feature branch env
Feature Branch Link