Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store views2 in tables #11279

Merged
merged 13 commits into from
Jul 19, 2023
Merged

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented Jul 19, 2023

Description

Refactoring new views to be stored in the table object instead of in its own document

@adrinr adrinr requested a review from mike12345567 July 19, 2023 14:38
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2023

Codecov Report

Merging #11279 (1b313b6) into BUDI-7189-views-v2 (c56bba8) will increase coverage by 0.02%.
The diff coverage is 92.85%.

❗ Current head 1b313b6 differs from pull request most recent head ae0dba8. Consider uploading reports for the commit ae0dba8 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@                  Coverage Diff                   @@
##           BUDI-7189-views-v2   #11279      +/-   ##
======================================================
+ Coverage               73.50%   73.53%   +0.02%     
======================================================
  Files                     307      307              
  Lines                   12928    12926       -2     
  Branches                 2679     2678       -1     
======================================================
+ Hits                     9503     9505       +2     
+ Misses                   3208     3204       -4     
  Partials                  217      217              
Impacted Files Coverage Δ
...ackages/server/src/api/controllers/row/internal.ts 85.15% <0.00%> (-0.12%) ⬇️
packages/server/src/api/routes/row.ts 100.00% <ø> (ø)
...er/src/migrations/functions/backfill/app/tables.ts 93.75% <50.00%> (-6.25%) ⬇️
packages/server/src/api/controllers/row/index.ts 95.57% <90.90%> (-0.58%) ⬇️
packages/server/src/sdk/app/views/index.ts 96.42% <96.29%> (+0.13%) ⬆️
packages/server/src/api/controllers/query/index.ts 81.76% <100.00%> (ø)
...ackages/server/src/api/controllers/row/external.ts 92.47% <100.00%> (+0.08%) ⬆️
packages/server/src/api/controllers/view/views.ts 92.24% <100.00%> (ø)
...ackages/server/src/api/controllers/view/viewsV2.ts 100.00% <100.00%> (+3.57%) ⬆️
packages/server/src/api/routes/view.ts 100.00% <100.00%> (ø)
... and 2 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@adrinr adrinr merged commit 1aaddcc into BUDI-7189-views-v2 Jul 19, 2023
8 checks passed
@adrinr adrinr deleted the BUDI-7189/store_views2_in_tables branch July 19, 2023 20:57
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants