Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement search views #11263

Merged
merged 13 commits into from
Jul 19, 2023
Merged

Implement search views #11263

merged 13 commits into from
Jul 19, 2023

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented Jul 18, 2023

Description

Implement search views

Dependant: https://github.com/Budibase/budibase-pro/pull/206

@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2023

Codecov Report

Merging #11263 (fa54832) into BUDI-7189-views-v2 (c56bba8) will increase coverage by 0.01%.
The diff coverage is 88.23%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@                  Coverage Diff                   @@
##           BUDI-7189-views-v2   #11263      +/-   ##
======================================================
+ Coverage               73.50%   73.51%   +0.01%     
======================================================
  Files                     307      307              
  Lines                   12928    12938      +10     
  Branches                 2679     2680       +1     
======================================================
+ Hits                     9503     9512       +9     
- Misses                   3208     3209       +1     
  Partials                  217      217              
Impacted Files Coverage Δ
...ackages/server/src/api/controllers/row/internal.ts 85.15% <0.00%> (-0.12%) ⬇️
packages/server/src/api/routes/row.ts 100.00% <ø> (ø)
packages/server/src/api/controllers/row/index.ts 95.57% <90.90%> (-0.58%) ⬇️
packages/server/src/api/controllers/query/index.ts 81.76% <100.00%> (ø)
...ackages/server/src/api/controllers/row/external.ts 92.47% <100.00%> (+0.08%) ⬆️
packages/server/src/sdk/app/rows/search.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@adrinr adrinr marked this pull request as ready for review July 18, 2023 13:48
Base automatically changed from BUDI-7189/views-crud to BUDI-7189-views-v2 July 18, 2023 16:34
@adrinr adrinr requested a review from mike12345567 July 18, 2023 23:14
@adrinr adrinr requested a review from Rory-Powell July 19, 2023 10:45
Copy link
Contributor

@Rory-Powell Rory-Powell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrinr adrinr merged commit 2cd6c4c into BUDI-7189-views-v2 Jul 19, 2023
8 checks passed
@adrinr adrinr deleted the BUDI-7189/search-views branch July 19, 2023 10:58
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants