Merge pull request #239 from Brixel/dont-track-projected-entities

fix: Ensure projected entities are not tracked
Brixel · Oct 13, 2023 · 283fbc6 · 283fbc6
2 parents a5b121d + 34658f4
commit 283fbc6
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 0 deletions.
diff --git a/Queries/BankAccounts/GetBankAccountById.cs b/Queries/BankAccounts/GetBankAccountById.cs
@@ -21,6 +21,7 @@ public GetBankAccountByIdHandler(IMapper mapper, HaSpManContext context)
 
     public Task<BankAccountDetail> Handle(GetBankAccountByIdQuery request, CancellationToken cancellationToken)
         => _context.BankAccounts
+            .AsNoTracking()
             .Where(b => b.Id == request.Id)
             .ProjectTo<BankAccountDetail>(_mapper.ConfigurationProvider)
             .SingleAsync(cancellationToken);

diff --git a/Queries/BankAccounts/SearchBankAccounts.cs b/Queries/BankAccounts/SearchBankAccounts.cs
@@ -48,6 +48,7 @@ public async Task<Paginated<BankAccountDetailWithTotal>> Handle(SearchBankAccoun
         bankAccountsQueryable = GetOrderedQueryable(request, bankAccountsQueryable);
 
         var bankAccountsDetailQueryable = bankAccountsQueryable
+            .AsNoTracking()
             .ProjectTo<BankAccountDetailWithTotal>(_mapper.ConfigurationProvider)
             .Skip(request.PageIndex * request.PageSize)
             .Take(request.PageSize);

diff --git a/Queries/FinancialYears/GetFinancialYearsQuery.cs b/Queries/FinancialYears/GetFinancialYearsQuery.cs
@@ -19,6 +19,7 @@ public async Task<IReadOnlyList<FinancialYear>> Handle(GetFinancialYearsQuery re
         CancellationToken cancellationToken)
     {
         return await _context.FinancialYears
+            .AsNoTracking()
             .OrderByDescending(x => x.StartDate)
             .Select(x => new FinancialYear(x.Id, x.StartDate, x.EndDate, x.IsClosed, x.Name))
             .ToListAsync(cancellationToken);

diff --git a/Queries/Members/Handlers/AutocompleteMember/AutocompleteCounterpartyHandler.cs b/Queries/Members/Handlers/AutocompleteMember/AutocompleteCounterpartyHandler.cs
@@ -17,6 +17,7 @@ public async Task<AutocompleteCounterpartyResponse> Handle(AutocompleteCounterpa
         if (request.IsMemberSearch)
         {
             var members = await _context.Members
+                .AsNoTracking()
                 .Where(x =>
                     x.FirstName.ToLower().Contains(request.SearchString.ToLower()) ||
                     x.LastName.ToLower().Contains(request.SearchString.ToLower()))

diff --git a/Queries/Members/Handlers/GetMemberById/GetMemberByIdHandler.cs b/Queries/Members/Handlers/GetMemberById/GetMemberByIdHandler.cs
@@ -21,6 +21,7 @@ public GetMemberByIdHandler(IMapper mapper, HaSpManContext context)
 
     public Task<MemberDetail> Handle(GetMemberByIdQuery request, CancellationToken cancellationToken)
         => _context.Members
+            .AsNoTracking()
             .Where(m => m.Id == request.Id)
             .ProjectTo<MemberDetail>(_mapper.ConfigurationProvider)
             .SingleAsync(cancellationToken);

diff --git a/Queries/Members/Handlers/SearchMembers/SearchMembersHandler.cs b/Queries/Members/Handlers/SearchMembers/SearchMembersHandler.cs
@@ -41,6 +41,7 @@ public async Task<Paginated<MemberSummary>> Handle(SearchMembersQuery request, C
         var orderedQueryable = GetOrderedQueryable(request, memberQueryable);
 
         var memberSummaryQueryable = orderedQueryable
+            .AsNoTracking()
             .Select(x => new MemberSummary(x.Id, x.Name, x.Address.ToString(), x.Email!, x.PhoneNumber!, x.IsActive(), x.MembershipExpiryDate))
             .Skip(request.PageIndex * request.PageSize)
             .Take(request.PageSize);

diff --git a/Queries/Transactions/Handlers/GetTransactionByIdHandler.cs b/Queries/Transactions/Handlers/GetTransactionByIdHandler.cs
@@ -20,6 +20,7 @@ public GetTransactionByIdHandler(HaSpManContext dbContext, IMapper mapper)
     }
     public Task<TransactionDetail> Handle(GetTransactionByIdQuery request, CancellationToken cancellationToken)
         => _dbContext.FinancialYears
+            .AsNoTracking()
             .SelectMany(x => x.Transactions)
             .Where(x => x.Id == request.Id)
             .ProjectTo<TransactionDetail>(_mapper.ConfigurationProvider)

diff --git a/Queries/Transactions/Handlers/GetTransactionsHandler.cs b/Queries/Transactions/Handlers/GetTransactionsHandler.cs
@@ -34,6 +34,7 @@ public async Task<Paginated<TransactionSummary>> Handle(GetTransactionQuery requ
         var transactions = GetOrderedQueryable(request, baseQuery);
 
         var transactionViewModels = transactions
+            .AsNoTracking()
             .ProjectTo<TransactionSummary>(_mapper.ConfigurationProvider)
             .Skip(request.PageIndex * request.PageSize)
             .Take(request.PageSize);