Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: select an option when there are several radio-group #882

Conversation

deeved-hiuston-brisa
Copy link
Contributor

@deeved-hiuston-brisa deeved-hiuston-brisa commented Oct 18, 2023

Issue Number

fix #881

Description

This PR proposes to fix the following issue: when you have more than one radio-group on the screen and select an option by clicking on a label that does not belong to the first group, an option from the first group is always selected.

Proposed Changes

  • The name of the radio-group was added to the option id (radio);
  • Test adaptation.

Screenshots

Problem

error.when.selecting.a.radio-group.option.mp4

Corretion

correction.when.selecting.a.radio-group.option.mp4

…-on-the-label-when-there-are-several-radio-group-on-the-screen
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that make sense create a new case with two radio groups with differents names and check select one radio item.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well thought!

…el-when-there-are-several-radio-group-on-the-screen' of github.com:Brisanet/ion into 881-fix-when-selecting-an-option-by-clicking-on-the-label-when-there-are-several-radio-group-on-the-screen
…-on-the-label-when-there-are-several-radio-group-on-the-screen
Copy link
Member

@iurynogueira iurynogueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well!

…-on-the-label-when-there-are-several-radio-group-on-the-screen
@alysson-mascarenhas-brisa alysson-mascarenhas-brisa merged commit caacdf9 into main Oct 26, 2023
3 checks passed
@alysson-mascarenhas-brisa alysson-mascarenhas-brisa deleted the 881-fix-when-selecting-an-option-by-clicking-on-the-label-when-there-are-several-radio-group-on-the-screen branch October 26, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix when selecting an option by clicking on the label when there are several radio-group on the screen
3 participants