fix: ion input button (#873) #875
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: ion input button * fix: clear button styles * refactor: scss functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: ion input button
fix: clear button styles
refactor: scss functions
Issue Number
fix #807
Description
Provide a clear and concise description of your change. Explain why this change is necessary and how it improves the project. Include links to related issues, if any.
Proposed Changes
How to Test
Provide detailed instructions on how to test the proposed changes. Include information on which test scenarios you covered and how you tested.
Screenshots
Include screenshots or GIFs that illustrate the proposed changes. This can be especially useful for user interface changes.
View Storybook
Provide a link to the chromatic Storybook that shows the proposed changes so reviewers can easily see the changes in action.
Please also be aware that in addition to the Chromatic link, the link in the pull request description will also need to be updated whenever changes are made.
How can I access the Chromatic link?
Open the pull request that you wish to verify the Storybook Chromatic on.
At the bottom of the "Checks" comment, click on "Details" next to the "Chromatic/chromatic-deployment" status.
On the "Checks" page, you will see a list of checks. Select the "Publish to Chromatic" section.
Scroll down until you find the section "View your Storybook at https://examplelink", that represents the desired link.
Compliance
References
List any additional references or documentation that you used when making this change.
Concluding
Remember that the goal of this template is to provide guidance and facilitate communication between developers, so feel free to include any additional information that you find useful. Make sure to check the project's policies and guidelines before submitting the pull request.