863 feat accordion group #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
alysson-mascarenhas-brisa
approved these changes
Oct 9, 2023
iurynogueira
requested changes
Oct 9, 2023
projects/ion/src/lib/accordion-group/accordion-group.component.spec.ts
Outdated
Show resolved
Hide resolved
projects/ion/src/lib/accordion-group/accordion-group.component.html
Outdated
Show resolved
Hide resolved
projects/ion/src/lib/accordion-group/accordion-group.component.spec.ts
Outdated
Show resolved
Hide resolved
deeved-hiuston-brisa
requested review from
iurynogueira and
alysson-mascarenhas-brisa
|
Missing divider here
|
…to 863-feat-accordion-group
iurynogueira
requested changes
Oct 16, 2023
projects/ion/src/lib/accordion/accordion-item/accordion-item.component.html
Outdated
Show resolved
Hide resolved
Comment on lines
86
to
92
| try { | ||
| await sut(); | ||
| } catch (error) { | ||
| expect(error.message).toBe( | ||
| 'The name or templateHeader properties were not set correctly' | ||
| ); | ||
| } |
…omponent.html refator: removing code duplication Co-authored-by: Iury Nogueira <[email protected]>
refactor: improving code Co-authored-by: Iury Nogueira <[email protected]>
iurynogueira
approved these changes
Oct 16, 2023
alysson-mascarenhas-brisa
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
feat #863
Description
Accordion group is a container that wraps multiple accordions and applies specific styles
Screenshots
View Storybook
https://62eab350a45bdb0a5818520e-tyaqlhoeyu.chromatic.com/?path=/story/ion-data-display-accordion--accordion