[MI-2949]:Added a check to remove pre existing autolinks #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raghavaggarwal2308
approved these changes
Apr 10, 2023
avas27JTG
approved these changes
Jan 18, 2024
mickmister
reviewed
Jan 30, 2024
Comment on lines
+403
to
+411
| var keys []string | ||
| for _,autolink:= range installList { | ||
| keys = append(keys,autolink.Name) | ||
| } | ||
|
|
||
| // Deleting the old autolinks if already present | ||
| if err := client.Delete(keys...); err != nil { | ||
| return fmt.Errorf("unable to delete autolinks: %w", err) | ||
| } |
There was a problem hiding this comment.
@avas27JTG This will likely have issues in HA environments, with multiple instances of the plugin running at the same time. They will be fighting over reading/deleting/creating the autolinks. @hanzei What are your thoughts on this?
There was a problem hiding this comment.
Can we simply have a giant lock around the function and check first, if the autolinks need to get generated?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mattermost#871 (comment)