update sliding window clustering FCCee with k4geo #18
Conversation
|
Thanks @dasphy , I'll merge after HEP-FCC/k4RecCalorimeter#58 and |
FCCSW_ecal/run_thetamodulemerged.py
Outdated
| @@ -4,7 +4,9 @@ | |||
| from Configurables import PodioOutput | |||
| from Configurables import CorrectCaloClusters | |||
| from Configurables import CreateCaloClustersSlidingWindow | |||
There was a problem hiding this comment.
if CreateCaloClustersSlidingWindow is not used anymore, can you remove this line?
FCCSW_ecal/run_thetamodulemerged.py
Outdated
| @@ -4,7 +4,9 @@ | |||
| from Configurables import PodioOutput | |||
| from Configurables import CorrectCaloClusters | |||
| from Configurables import CreateCaloClustersSlidingWindow | |||
| from Configurables import CreateCaloClustersSlidingWindowFCCee | |||
| from Configurables import CaloTowerTool | |||
There was a problem hiding this comment.
if CaloTowerTool is not used anymore, can you remove this line?
FCCSW_ecal/run_thetamodulemerged.py
Outdated
| @@ -414,7 +414,8 @@ | |||
| hcalEndcapReadoutName="", | |||
| hcalFwdReadoutName="", | |||
| OutputLevel=INFO) | |||
| towers.ecalBarrelCells.Path = ecalBarrelCellsName | |||
| towers.ecalBarrelCells.Path = ecalBarrelPositionedCellsName | |||
| #towers.ecalBarrelCells.Path = ecalBarrelCellsName | |||
There was a problem hiding this comment.
can you remove this commented line?
Hi @BrieucF Tagging: @giovannimarchiori , @gartrog |
|
Great! It looks good to me. Any further comment @giovannimarchiori ? @dasphy can you also port this to https://github.com/HEP-FCC/FCC-config/blob/main/FCCee/FullSim/ALLEGRO/ALLEGRO_o1_v02/run_digi_reco.py ? This repository will host clean configurations for the digitization and reconstruction of the full FCC detectors concepts, in view of future central productions. |
OK no problem |
Looks good to me, thanks! |
Hello @BrieucF , @kjvbrt
PR #16 is discarded, this PR is the replacement.
@giovannimarchiori
@gartrog
Tong