Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf() : replace jscs with eslint #933

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

JagadeeshKaricherla-branch
Copy link
Contributor

@JagadeeshKaricherla-branch JagadeeshKaricherla-branch commented Sep 14, 2023

Pull Request Template

Description

Replace linting tool from jscs ( package deprecated ) to eslint

Fixes # (issue)

Type of change : performance

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit test
  • Integration test

JS Budget Check

Please mention the size in kb before abd after this PR

Files Before After
dist/build.js.
dist/build.min.js

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Mentions:

List the person or team responsible for reviewing proposed changes.

cc @BranchMetrics/saas-sdk-devs for visibility.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

Test Results

112 tests   105 ✔️  56s ⏱️
    1 suites      7 💤
    1 files        0

Results for commit 9a0b770.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@ce035be). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #933   +/-   ##
=========================================
  Coverage          ?   24.60%           
=========================================
  Files             ?       15           
  Lines             ?     2321           
  Branches          ?        0           
=========================================
  Hits              ?      571           
  Misses            ?     1750           
  Partials          ?        0           

fix linting issues reated to double quotes
@@ -0,0 +1,2 @@
node_modules/
dist/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should newline eof char be added?

@gdeluna-branch
Copy link

Most of these changes are just from executing the eslint tool right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants