This repository has been archived by the owner on Feb 29, 2024. It is now read-only.
Fixup vagrant port forwards #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Match the 808X port to the .10X ip address. This was already the case for most 808X ports, but both logs and backups were trying to use port 8085. Since backups uses ip address .105, use the port on that host. The logs host uses ip address .102 so use port 8082 on that host. Also add a direct port forward for kibana to bypass the apache reverse proxy in front of it. Signed-off-by: K Jonathan Harker <[email protected]>
mlangbehn
reviewed
May 5, 2017
| @@ -159,6 +159,7 @@ Vagrant.configure(2) do |config| | |||
| elk.vm.hostname = 'elk.vagrant' | |||
| elk.vm.network "private_network", ip: "10.0.0.104" | |||
| elk.vm.network "forwarded_port", guest: 80, host: 8084 | |||
| elk.vm.network "forwarded_port", guest: 5601, host: 5601 | |||
There was a problem hiding this comment.
@jesusaurus: can you explain why we are this change?
There was a problem hiding this comment.
This is a stale change I meant to make a few days ago. It allows a dev to hit kibana directly rather than going through the apache reverse proxy. We added a default deny vhost to the apache config here, so you need a hostname match to hit the correct vhost to proxy to kibana.
There was a problem hiding this comment.
Okay, that sounds like a great change to add. Since this change is for fixing vagrant port issues, it all looks good to me.
mlangbehn
approved these changes
May 5, 2017
| @@ -159,6 +159,7 @@ Vagrant.configure(2) do |config| | |||
| elk.vm.hostname = 'elk.vagrant' | |||
| elk.vm.network "private_network", ip: "10.0.0.104" | |||
| elk.vm.network "forwarded_port", guest: 80, host: 8084 | |||
| elk.vm.network "forwarded_port", guest: 5601, host: 5601 | |||
There was a problem hiding this comment.
Okay, that sounds like a great change to add. Since this change is for fixing vagrant port issues, it all looks good to me.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match the 808X port to the .10X ip address. This was already the case
for most 808X ports, but both logs and backups were trying to use port
8085. Since backups uses ip address .105, use the port on that host. The
logs host uses ip address .102 so use port 8082 on that host.
Also add a direct port forward for kibana to bypass the apache reverse
proxy in front of it.
Signed-off-by: K Jonathan Harker [email protected]